Review Request 127523: Only link with MYSQL_EMBEDDED_LIBRARIES if WITH_MYSQL_EMBEDDED

[Soren Harward]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127523/#review94135
-----------------------------------------------------------


Ship it!




If we are providing a build option that allows MySQL Embedded to be disabled — and we are — then that build option should work. If it doesn't work, then it should be removed or fixed.  We have a patch for the latter, so let's do it.

- Soren Harward


On March 29, 2016, 4:27 p.m., Matt Whitlock wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127523/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 4:27 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> This patch corrects a build failure when compiling Amarok without MySQL Embedded.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/mysqlcollection/CMakeLists.txt 244cde1 
> 
> Diff: https://git.reviewboard.kde.org/r/127523/diff/
> 
> 
> Testing
> -------
> 
> See [Gentoo bug 566980](https://bugs.gentoo.org/show_bug.cgi?id=566980).
> 
> 
> Thanks,
> 
> Matt Whitlock
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160330/5918a0c6/attachment-0001.html>