Review Request 127458: Fix for 2 warnings, one of them a probable bug

Myriam Schweingruber myriam at kde.org
Tue Mar 22 12:58:00 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127458/#review93864
-----------------------------------------------------------


Ship it!




Ship It!

- Myriam Schweingruber


On March 22, 2016, 12:03 a.m., Stefano Pettini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127458/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 12:03 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> This fixes two minor C++ warnings: one unused variable and another one about operator precedence. However I think the last one was I bug, that I think I fixed. It was about bpm in SqlScanProcessor
> 
> 
> Diffs
> -----
> 
>   src/configdialog/dialogs/DatabaseConfig.cpp 1cb2d97 
>   src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp ea9c911 
> 
> Diff: https://git.reviewboard.kde.org/r/127458/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stefano Pettini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160322/e2a91c28/attachment.html>


More information about the Amarok-devel mailing list