Review Request 128418: Fix MPRIS2 DesktopEntry value

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128418/#review97494
-----------------------------------------------------------



Can we just KAboutData desktopFileName or something like that? I fear when it gets renamed to org.kde.amarok at one point it'll break again.

- Kai Uwe Broulik


On Juli 10, 2016, 10:12 vorm., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128418/
> -----------------------------------------------------------
> 
> (Updated Juli 10, 2016, 10:12 vorm.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 365275
>     https://bugs.kde.org/show_bug.cgi?id=365275
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> According to the MPRIS2 spec, the DesktopEntry value should be "the basename of the .desktop file" [1], not the desktop-file-id. So for amarok it should be "amarok" and not "kde4-amarok", regardless of where the desktop file is installed. This fixes displaying MPRIS controls in the Amarok taskbar tooltip in Plasma 5.7
> 
> [1] https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry
> 
> 
> Diffs
> -----
> 
>   src/dbus/mpris2/MediaPlayer2.cpp cbe1a2a 
> 
> Diff: https://git.reviewboard.kde.org/r/128418/diff/
> 
> 
> Testing
> -------
> 
> Player controls are displayed again in the Amarok taskbar tooltip in Plasma 5.7.
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160717/92ba2fa6/attachment.html>