Review Request 128418: Fix MPRIS2 DesktopEntry value
Antonio Rojas
nqn1976 at gmail.com
Sun Jul 10 10:12:42 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128418/
-----------------------------------------------------------
Review request for Amarok.
Bugs: 365275
https://bugs.kde.org/show_bug.cgi?id=365275
Repository: amarok
Description
-------
According to the MPRIS2 spec, the DesktopEntry value should be "the basename of the .desktop file" [1], not the desktop-file-id. So for amarok it should be "amarok" and not "kde4-amarok", regardless of where the desktop file is installed. This fixes displaying MPRIS controls in the Amarok taskbar tooltip in Plasma 5.7
[1] https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry
Diffs
-----
src/dbus/mpris2/MediaPlayer2.cpp cbe1a2a
Diff: https://git.reviewboard.kde.org/r/128418/diff/
Testing
-------
Player controls are displayed again in the Amarok taskbar tooltip in Plasma 5.7.
Thanks,
Antonio Rojas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160710/0e95d86d/attachment.html>
More information about the Amarok-devel
mailing list