Review Request 128418: Fix MPRIS2 DesktopEntry value

[Antonio Rojas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128418/
-----------------------------------------------------------

(Updated Aug. 20, 2016, 1:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Amarok.


Changes
-------

Submitted with commit 9449ec56d1fd77a0bfa1f7134a2bf4f91ffd14d3 by Mat?j Laitl on behalf of Antonio Rojas to branch master.


Bugs: 365275
    https://bugs.kde.org/show_bug.cgi?id=365275


Repository: amarok


Description
-------

According to the MPRIS2 spec, the DesktopEntry value should be "the basename of the .desktop file" [1], not the desktop-file-id. So for amarok it should be "amarok" and not "kde4-amarok", regardless of where the desktop file is installed. This fixes displaying MPRIS controls in the Amarok taskbar tooltip in Plasma 5.7

[1] https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry


Diffs
-----

  src/dbus/mpris2/MediaPlayer2.cpp cbe1a2a 

Diff: https://git.reviewboard.kde.org/r/128418/diff/


Testing
-------

Player controls are displayed again in the Amarok taskbar tooltip in Plasma 5.7.


Thanks,

Antonio Rojas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20160820/1bfd0e3f/attachment-0001.html>