Review Request 125059: Fix for Amarok's kf5 branch failing to build

Somsubhra Bairi somsubhra.bairi at gmail.com
Sat Sep 5 18:41:03 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125059/
-----------------------------------------------------------

(Updated Sept. 5, 2015, 6:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for Amarok.


Changes
-------

Submitted with commit 8725c83ad3c80632d22c0db7c05115605f1b2d6e by Somsubhra Bairi to branch kf5.


Repository: amarok


Description
-------

Fix for Amarok's kf5 branch failing to build. Right now it throws the following error:

CMakeFiles/amarok_storage-mysqlserverstorage.dir/MySqlServerStorageFactory.cpp.o: In function `factory::factory()':
/home/somsubhra/kde/src/amarok/src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorageFactory.cpp:23: undefined reference to `vtable for factory'
CMakeFiles/amarok_storage-mysqlserverstorage.dir/MySqlServerStorageFactory.cpp.o: In function `factory::~factory()':
/home/somsubhra/kde/src/amarok/src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorageFactory.cpp:23: undefined reference to `vtable for factory'
collect2: error: ld returned 1 exit status

So added the necessary meta object compiler generated file.


Diffs
-----

  src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorageFactory.cpp dd86d0d 

Diff: https://git.reviewboard.kde.org/r/125059/diff/


Testing
-------

Amarok builds successfully.


Thanks,

Somsubhra Bairi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150905/996ff215/attachment-0001.html>


More information about the Amarok-devel mailing list