Review Request 125872: threadweaver issue solved
rishabh gupta
rishabh9511 at gmail.com
Fri Oct 30 05:56:17 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125872/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 5:56 a.m.)
Review request for Amarok, Stefan Derkits and Olivier Churlaud.
Changes
-------
added d->woker->deletaLater();
Repository: amarok
Description
-------
removed the code that was deleting the threadeweaver::job .it's a qsharedpointer so it shouldn't be deleted manaully
Diffs (updated)
-----
src/core-impl/collections/db/sql/SqlQueryMaker.cpp c73a551
Diff: https://git.reviewboard.kde.org/r/125872/diff/
Testing
-------
builds 100%
testing done
Thanks,
rishabh gupta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151030/739c27cc/attachment.html>
More information about the Amarok-devel
mailing list