Review Request 125872: threadweaver issue solved

[Olivier Churlaud]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125872/#review87691
-----------------------------------------------------------

Ship it!


Ship It!

- Olivier Churlaud


On oct. 29, 2015, 6:12 après-midi, rishabh  gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125872/
> -----------------------------------------------------------
> 
> (Updated oct. 29, 2015, 6:12 après-midi)
> 
> 
> Review request for Amarok, Stefan Derkits and Olivier Churlaud.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> removed the code that was  deleting the threadeweaver::job .it's a qsharedpointer so it shouldn't be deleted manaully
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/SqlQueryMaker.cpp c73a551 
> 
> Diff: https://git.reviewboard.kde.org/r/125872/diff/
> 
> 
> Testing
> -------
> 
> builds 100%
> testing done
> 
> 
> Thanks,
> 
> rishabh  gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151029/4883bac3/attachment-0001.html>