[Port KF5] Why we get so many segfault...

[Aroonav Mishra]

Hello,

Sorry for not being able to get back to you on IRC. I have been busy with
another project of mine at my university for quite some time now.

If a method was virtual before and is pure virtual now then one can't call
that function as the method is of an abstract class now in Qt5 (and hence
can't be instantiated). Just removing these function calls won't help
either as the classes that derive from these will also remain an abstract
class until these pure virtual functions are reimplemented in the derived
classes.

So the calls to these specific functions will automatically turn up as
errors during the compilation process (thus automatically highlighting the
need to take care of the now pure virtual function). Can you please explain
why then is it needed to use pragma in these cases?

Regards,
Aroonav.

On 20 October 2015 at 22:44, Olivier Churlaud <olivier at churlaud.com> wrote:

> Hi,
>
> I found why we get so many nasty segfault...
>
> Several methods of Qt4 (which were virtual) are now (with Qt5) pure
> virtual, meaning that they are defined like:
>         virtual void myfunction( ...args...) = 0 ;
>
> Therefore calling them produces a segfault...
>
> IMO, we should first comment them with, before the line
>         #pragma message("PORTKF5: X lines here")
> so that at compilation time we can easily find what still needs to be
> changed.
>
> After that, we'll have to either remove the lines or reimplement them.
>
> Cheers & Have fun!
> Olivier
>
> --
> Olivier CHURLAUD
> Engineer Student at Ecole Centrale de Lyon
> in Dual Degree at TU Berlin, M.Sc. Elektrotechnik
> @: olivier at churlaud.com
> tel: +49 (0)1575-2931348
> in:  http://linkedin.com/in/olivierchurlaud
> web: http://olivier.churlaud.com
>
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151022/19f7963b/attachment.html>