[Port KF5] Aditya's commit

Aditya Sharma aditya.sharma15696 at gmail.com
Tue Oct 13 21:02:23 UTC 2015


>
> Please forget the message I sent (see below). I wasn't on the good branch.
>
> @Aditya: Just take in account my advice for the commits.
>

Sure. Thanks for pointing that out :)


>
> Cheers, and keep up the good job!
> Olivier
>
> ---
> Hi,
>
> Aditya's commit prevent me to compile to 100%, which is a regression. Is
> it the same for you?
>
> Here is my output: https://paste.kde.org/pk9zp5xaj (the beginning is
> missing, sorry for this)
>
> Furthermore, your commit message should be more explicit Aditya: REVIEW:
> 125519 is not enough.
>
> Cheers,
> Olivier
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151014/3f30166c/attachment.html>


More information about the Amarok-devel mailing list