Fwd: [Port KF5] Aditya's commit

Olivier Churlaud olivier at churlaud.com
Tue Oct 13 20:58:02 UTC 2015


Please forget the message I sent (see below). I wasn't on the good branch.

@Aditya: Just take in account my advice for the commits.

Cheers, and keep up the good job!
Olivier

---
Hi,

Aditya's commit prevent me to compile to 100%, which is a regression. Is
it the same for you?

Here is my output: https://paste.kde.org/pk9zp5xaj (the beginning is
missing, sorry for this)

Furthermore, your commit message should be more explicit Aditya: REVIEW:
125519 is not enough.

Cheers,
Olivier




More information about the Amarok-devel mailing list