Review Request 126128: Port EqualizerDialog
Olivier Churlaud
olivier at churlaud.com
Tue Nov 24 22:04:59 UTC 2015
> On nov. 24, 2015, 11:02 après-midi, Ralf Engels wrote:
> > Patch doesn't apply on git master.
> > What version are you based on? What is the last commit you see with "git log"?
> >
> > Also here is something to read for providing patches:
> > http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html
Sorry, I only work on the kf5 branch. I wrote it in the <branch> menu and thought it was enough.
So it goes on top of the KF5 branch
- Olivier
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126128/#review88772
-----------------------------------------------------------
On nov. 21, 2015, 4:02 après-midi, Olivier Churlaud wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126128/
> -----------------------------------------------------------
>
> (Updated nov. 21, 2015, 4:02 après-midi)
>
>
> Review request for Amarok and Ralf Engels.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> EqualizerDialog is now a QDialog
>
>
> Diffs
> -----
>
> src/dialogs/EqualizerDialog.h 53654b6
> src/dialogs/EqualizerDialog.cpp 936fd20
> src/dialogs/EqualizerDialog.ui 7fc5a7d
>
> Diff: https://git.reviewboard.kde.org/r/126128/diff/
>
>
> Testing
> -------
>
> Compiles, run, behave correctly.
>
>
> Thanks,
>
> Olivier Churlaud
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151124/c8e00192/attachment.html>
More information about the Amarok-devel
mailing list