Review Request 126128: Port EqualizerDialog

Ralf Engels ralf-engels at gmx.de
Tue Nov 24 22:02:24 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126128/#review88772
-----------------------------------------------------------


Patch doesn't apply on git master.
What version are you based on? What is the last commit you see with "git log"?

Also here is something to read for providing patches:
http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html

- Ralf Engels


On Nov. 21, 2015, 3:02 nachm., Olivier Churlaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126128/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2015, 3:02 nachm.)
> 
> 
> Review request for Amarok and Ralf Engels.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> EqualizerDialog is now a QDialog
> 
> 
> Diffs
> -----
> 
>   src/dialogs/EqualizerDialog.h 53654b6 
>   src/dialogs/EqualizerDialog.cpp 936fd20 
>   src/dialogs/EqualizerDialog.ui 7fc5a7d 
> 
> Diff: https://git.reviewboard.kde.org/r/126128/diff/
> 
> 
> Testing
> -------
> 
> Compiles, run, behave correctly.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151124/66d99947/attachment.html>


More information about the Amarok-devel mailing list