Review Request 122226: Some I18N fixes

Chusslove Illich caslav.ilic at gmx.net
Sun Feb 1 10:23:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122226/#review75128
-----------------------------------------------------------

Ship it!


>From the i18n point of view, all as it should be. Messages with integer amounts must use plural calls regardless if number >= 2. Messages with multiple amounts should be split and cross-referenced through contexts. Maintainers should check the rest (coding style...).

- Chusslove Illich


On Јан. 23, 2015, 6:44 по п., Safa Alfulaij wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122226/
> -----------------------------------------------------------
> 
> (Updated Јан. 23, 2015, 6:44 по п.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Fix some plural strings.
> Make a comma separator translatable.
> Get rid of some puzzle strings.
> 
> 
> Diffs
> -----
> 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp bd4f6d6 
>   src/covermanager/CoverManager.cpp c56382b 
>   src/playlistgenerator/constraints/PlaylistLength.cpp 224ce94 
> 
> Diff: https://git.reviewboard.kde.org/r/122226/diff/
> 
> 
> Testing
> -------
> 
> Didn't test it, Just by logic.
> 
> 
> Thanks,
> 
> Safa Alfulaij
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150201/19c21e30/attachment.html>


More information about the Amarok-devel mailing list