Review Request 126171: Compare directories finishing by trailing slash

[Olivier Churlaud]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126171/
-----------------------------------------------------------

(Updated Dec. 2, 2015, 8:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for Amarok, Maximilian Kossick and Ralf Engels.


Changes
-------

Submitted with commit 8c8392e95455bd9bf83fa4ddc910f9835351aa3b by Olivier CHURLAUD to branch kf5.


Repository: amarok


Description
-------

[This goes on the KF5 branch]

After porting KUrl to QUrls it appeared that the folders where not saved in the database. I found the reason and did a dirty fix:

src/core-impl/collections/db/sql/SqlScqnResultProcessor.cpp:401
-       if( !m_foundDirectories.contains( path ) )
+       if( !m_foundDirectories.contains( path +'/' ) )

The patch here should take the problem at its source and correct it in a good way.

I had other alternatives in a mail I sent [1] (but I didn't get any answer)

[1] https://mail.kde.org/pipermail/amarok-devel/2015-November/013852.html


Diffs
-----

  src/core-impl/collections/db/MountPointManager.cpp e14cb18 

Diff: https://git.reviewboard.kde.org/r/126171/diff/


Testing
-------

Build, and folders saved in the database


Thanks,

Olivier Churlaud

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151202/70ad23d1/attachment.html>