Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

[Olivier Churlaud]

Hi, while reading this I ask myself if it complies with the HiG (
https://techbase.kde.org/Projects/Usability/HIG). For instance Ctrl+A, Ctrl+Shift+C...

Furthermore, i'm not sure it's relevant to impose this. It should just be editable in the shortkeys edition window.

It's just what I think but if you add discussions on this before, please tell me and forget about the mail ;)

Cheers
Olivier



Sur 17 août 2015 09:26, à 09:26, Aditya Dev Sharma <aditya.sharma15696 at gmail.com> a écrit:
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://git.reviewboard.kde.org/r/124773/
>-----------------------------------------------------------
>
>(Updated Aug. 17, 2015, 7:26 a.m.)
>
>
>Review request for Amarok.
>
>
>Bugs: 300979
>    https://bugs.kde.org/show_bug.cgi?id=300979
>
>
>Repository: amarok
>
>
>Description
>-------
>
>JJ : Bug - 300979 : Patch to add some shortcuts for various actions in
>createActions() in MainWindow
>
>
>Diffs
>-----
>
>  src/MainWindow.cpp 22fb8ce 
>
>Diff: https://git.reviewboard.kde.org/r/124773/diff/
>
>
>Testing (updated)
>-------
>
>Built and tested.
>
>Initially added some more shortcuts but couldn't test them. Will have
>to go through the Amarok User Hand Book to see how are things supposed
>to go. So will update in a day or two.
>
>Action : Shortcut --------> SLOT
>
>Clear Playlist : CTRL + SHIFT + C  ---------------> SLOT(clear() )
>Add Stream : CTRL + A              --------------->
>SLOT(slotAddStream() ) 
>Export Playlits : CTRL + SHIFT + E --------------->
>SLOT(exportPlaylist() )
>Bookmarks Manager : CTRL + B       --------------->
>SLOT(slotShowBookmarkManager() )
>Equalizer : SHIFT + E              --------------->
>SLOT(slotShowEqualizer() )
>Cover Manager : CTRL + ALT + C     --------------->
>SLOT(slotShowCoverManager() )
>Synchronize Statistics : CTRL + S  ---------------> SLOT(synchronize()
>)
>
>/* Rev 2 */
>Bookmark Media Sources View : SHIFT + B ---------->
>SLOT(bookmarkCurrentBrowserView() )
>Bookmark Playlist Setup : ALT + B  --------------->
>bookmarkCurrentPlaylistView() )
>Bookmark Context Applets : CTRL + SHIFT + B ------>
>bookmarkCurrentContextView() ) 
>Disable Dynamic Playlist : ALT + SHIFT + D -------> connected inside
>dynamic playlist category
>
>/* Rev3 */
>About Amarok : CTRL + SHIFT + A  -----------------> SLOT(showAbout())
>Diagnostics  : CTRL + ALT + D    ----------------->
>SLOT(slotShowDiagnosticsDialog())
>Report bug   : ALT + SHIFT + R   ----------------->
>SLOT(showReportBug())
>
>
>Thanks,
>
>Aditya Dev Sharma
>
>
>
>------------------------------------------------------------------------
>
>_______________________________________________
>Amarok-devel mailing list
>Amarok-devel at kde.org
>https://mail.kde.org/mailman/listinfo/amarok-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150817/639fdb04/attachment-0002.html>