<html><head></head><body><p dir="ltr">Hi, while reading this I ask myself if it complies with the HiG (<br>
<a href="https://techbase.kde.org/Projects/Usability/HIG">https://techbase.kde.org/Projects/Usability/HIG</a>). For instance Ctrl+A, Ctrl+Shift+C...</p>
<p dir="ltr">Furthermore, i'm not sure it's relevant to impose this. It should just be editable in the shortkeys edition window.</p>
<p dir="ltr">It's just what I think but if you add discussions on this before, please tell me and forget about the mail ;)</p>
<p dir="ltr">Cheers<br>
Olivier<br><br></p>
<div class="gmail_quote" >Sur 17 août 2015, à 09:26, Aditya Dev Sharma <<a href="mailto:aditya.sharma15696@gmail.com" target="_blank">aditya.sharma15696@gmail.com</a>> a écrit:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124773/">https://git.reviewboard.kde.org/r/124773/</a>
</td>
</tr>
</tbody></table>
<br>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody><tr>
<td>
<div>Review request for Amarok.</div>
<div>By Aditya Dev Sharma.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2015, 7:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=300979">300979</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">JJ : Bug - 300979 : Patch to add some shortcuts for various actions in createActions() in MainWindow</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built and tested.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Initially added some more shortcuts but couldn't test them. Will have to go through the Amarok User Hand Book to see how are things supposed to go. So will update in a day or two.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Action : Shortcut --------> SLOT</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Clear Playlist : CTRL + SHIFT + C ---------------> SLOT(clear() )
Add Stream : CTRL + A ---------------> SLOT(slotAddStream() )
Export Playlits : CTRL + SHIFT + E ---------------> SLOT(exportPlaylist() )
Bookmarks Manager : CTRL + B ---------------> SLOT(slotShowBookmarkManager() )
Equalizer : SHIFT + E ---------------> SLOT(slotShowEqualizer() )
Cover Manager : CTRL + ALT + C ---------------> SLOT(slotShowCoverManager() )
Synchronize Statistics : CTRL + S ---------------> SLOT(synchronize() )</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">/<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> Rev 2 </em>/
Bookmark Media Sources View : SHIFT + B ----------> SLOT(bookmarkCurrentBrowserView() )
Bookmark Playlist Setup : ALT + B ---------------> bookmarkCurrentPlaylistView() )
Bookmark Context Applets : CTRL + SHIFT + B ------> bookmarkCurrentContextView() )
Disable Dynamic Playlist : ALT + SHIFT + D -------> connected inside dynamic playlist category</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">/<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> Rev3 </em>/
About Amarok : CTRL + SHIFT + A -----------------> SLOT(showAbout())
Diagnostics : CTRL + ALT + D -----------------> SLOT(slotShowDiagnosticsDialog())
Report bug : ALT + SHIFT + R -----------------> SLOT(showReportBug())</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.cpp <span style="color: grey">(22fb8ce)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124773/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
<pre class="blue"><hr><br>Amarok-devel mailing list<br>Amarok-devel@kde.org<br><a href="https://mail.kde.org/mailman/listinfo/amarok-devel">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br></pre></blockquote></div></body></html>