Review Request 120399: Amarok: If waiting on the fadeout to pause, prevent pausing again.

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120399/#review67549
-----------------------------------------------------------


The change looks good (it is an improvement wrt current situation), but perhaps we can do what you envisioned on the bug, i.e. pause instantenously when pause is pressed within pausin fadeout?

- Matěj Laitl


On Sept. 28, 2014, 2:39 a.m., Martin Lyth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120399/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2014, 2:39 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 339470
>     https://bugs.kde.org/show_bug.cgi?id=339470
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Don't call play or pause if we're already waiting on the timer to pause. See Bug 339470 for details on the bug, and the 1.5 lines of code are pretty self-explanatory.
> 
> 
> Diffs
> -----
> 
>   src/EngineController.cpp 19c483d 
> 
> Diff: https://git.reviewboard.kde.org/r/120399/diff/
> 
> 
> Testing
> -------
> 
> Still compiles, and pressing pause continuously no longer extends the timer infinitely.
> 
> 
> Thanks,
> 
> Martin Lyth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140928/bf384204/attachment.html>