Review Request 120399: Amarok: If waiting on the fadeout to pause, prevent pausing again.

Martin Lyth bsfmartini at gmail.com
Sun Sep 28 00:39:48 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120399/
-----------------------------------------------------------

Review request for Amarok.


Bugs: 339470
    https://bugs.kde.org/show_bug.cgi?id=339470


Repository: amarok


Description
-------

Don't call play or pause if we're already waiting on the timer to pause. See Bug 339470 for details on the bug, and the 1.5 lines of code are pretty self-explanatory.


Diffs
-----

  src/EngineController.cpp 19c483d 

Diff: https://git.reviewboard.kde.org/r/120399/diff/


Testing
-------

Still compiles, and pressing pause continuously no longer extends the timer infinitely.


Thanks,

Martin Lyth

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140928/980ede80/attachment.html>


More information about the Amarok-devel mailing list