Review Request 105875: Allow guessing of tags from filenames for multiple files

[Myriam Schweingruber]

> On Sept. 9, 2012, 11:53 a.m., Matěj Laitl wrote:
> > Good work and I agree that we should provide the funcitonality, but some issues need to be addressed first:
> >  * this patch contains both the feature and cleanups. Split it, create review request for all the cleaups and interface changes (to merged first) and then implement the feature in a commit that would contain _no_ cleanups or not-needed changes.
> >  * we generally favour Meta::val* over Meta::FIELD::*. In fact, my long-term goal is to ditch Meta::FIELD::* completely.
> >  * how the changes to the UI look like? How are multiple filenames shown in "Filename Layout Chooser"?

Matthias, this is waiting since quite some time for your input, we would love to include this in the upcoming 2.9, provided you make the requested changes and check it for current git.


- Myriam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/105875/#review18706
-----------------------------------------------------------


On Aug. 6, 2012, 12:14 p.m., Matthias Berndt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/105875/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 12:14 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 213074
>     https://bugs.kde.org/show_bug.cgi?id=213074
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Allow guessing of tags from filenames for multiple files
> (bug #213074).
> 
> Refactor some of the code in order to reuse some of the code intended
> for MusicBrainz
> 
> make the tag guessing dialog non-modal
> 
> 
> Diffs
> -----
> 
>   shared/TagsFromFileNameGuesser.cpp f2ec2ba 
>   src/core/meta/support/MetaConstants.h 41c78a9 
>   src/core/meta/support/MetaConstants.cpp 079fd22 
>   src/dialogs/FilenameLayoutDialog.cpp 1517a8a 
>   src/dialogs/TagDialog.h 015f2d3 
>   src/dialogs/TagDialog.cpp a448458 
>   src/dialogs/TagGuesser.h 432d38f 
>   src/dialogs/TagGuesser.cpp b1a503f 
> 
> Diff: https://git.reviewboard.kde.org/r/105875/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias Berndt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20141101/b025939d/attachment-0001.html>