<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/105875/">https://git.reviewboard.kde.org/r/105875/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 9th, 2012, 11:53 a.m. CEST, <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good work and I agree that we should provide the funcitonality, but some issues need to be addressed first:
* this patch contains both the feature and cleanups. Split it, create review request for all the cleaups and interface changes (to merged first) and then implement the feature in a commit that would contain _no_ cleanups or not-needed changes.
* we generally favour Meta::val* over Meta::FIELD::*. In fact, my long-term goal is to ditch Meta::FIELD::* completely.
* how the changes to the UI look like? How are multiple filenames shown in "Filename Layout Chooser"?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Matthias, this is waiting since quite some time for your input, we would love to include this in the upcoming 2.9, provided you make the requested changes and check it for current git.</p></pre>
<br />
<p>- Myriam</p>
<br />
<p>On August 6th, 2012, 12:14 p.m. CEST, Matthias Berndt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Matthias Berndt.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2012, 12:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=213074">213074</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allow guessing of tags from filenames for multiple files
(bug #213074).
Refactor some of the code in order to reuse some of the code intended
for MusicBrainz
make the tag guessing dialog non-modal</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/TagsFromFileNameGuesser.cpp <span style="color: grey">(f2ec2ba)</span></li>
<li>src/core/meta/support/MetaConstants.h <span style="color: grey">(41c78a9)</span></li>
<li>src/core/meta/support/MetaConstants.cpp <span style="color: grey">(079fd22)</span></li>
<li>src/dialogs/FilenameLayoutDialog.cpp <span style="color: grey">(1517a8a)</span></li>
<li>src/dialogs/TagDialog.h <span style="color: grey">(015f2d3)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(a448458)</span></li>
<li>src/dialogs/TagGuesser.h <span style="color: grey">(432d38f)</span></li>
<li>src/dialogs/TagGuesser.cpp <span style="color: grey">(b1a503f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/105875/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>