Review Request 112263: EBN: Check for foreach loop issues.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112263/#review58226
-----------------------------------------------------------


This review has been submitted with commit 5491d4ba8bdf8bcfba2a1f46cf2417c1b45f5914 by Vedant Agarwala on behalf of Frank Meerkoetter to branch tagguessing.

- Commit Hook


On Aug. 26, 2013, 10:11 a.m., Frank Meerkoetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112263/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 10:11 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> More janitor work.
> 
> EBN: Check for foreach loop issues.
> 
> Fixing a number of issues from
> http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
> [...]
> 13. Check for foreach loop issues [foreach]...
> [...]
> 
> Calling values() isn't necessary here. foreach will iterate over the values by default.
> 
> 
> Diffs
> -----
> 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 4d2352d 
>   src/context/applets/upcomingevents/UpcomingEventsStack.cpp dd9e149 
>   src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp f19ff4d 
>   src/core-impl/collections/support/MemoryMatcher.cpp 6e94647 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 793358b 
> 
> Diff: https://git.reviewboard.kde.org/r/112263/diff/
> 
> 
> Testing
> -------
> 
> Unit tests still pass.
> 
> 
> Thanks,
> 
> Frank Meerkoetter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140521/0b8ae139/attachment.html>