Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left overs)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112221/#review58224
-----------------------------------------------------------


This review has been submitted with commit dee7c2465cb744a13ff6cf183ce71510f66bff5b by Vedant Agarwala on behalf of Frank Meerkoetter to branch tagguessing.

- Commit Hook


On Aug. 25, 2013, 8:45 a.m., Frank Meerkoetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112221/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2013, 8:45 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 313504
>     https://bugs.kde.org/show_bug.cgi?id=313504
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Fix the few remaining cases i missed on the first run. See: https://git.reviewboard.kde.org/r/112148/
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/umscollection/UmsCollection.cpp ad38461 
>   src/dialogs/DiagnosticDialog.cpp a5f2e17 
>   tests/synchronization/TestOneWaySynchronizationJob.cpp e7829b4 
> 
> Diff: https://git.reviewboard.kde.org/r/112221/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass.
> 
> 
> Thanks,
> 
> Frank Meerkoetter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140521/51803d5b/attachment.html>