Review Request 117580: Patch for "AFT tagger always recalculating a new tag in m4a/mp4 files"

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117580/#review57613
-----------------------------------------------------------


This review has been submitted with commit dca658b98adaa843699dfbcc267dac0c2f00b350 by Daniel Meltzer to branch master.

- Commit Hook


On April 16, 2014, 9:09 a.m., Stefano Pettini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117580/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 9:09 a.m.)
> 
> 
> Review request for Amarok and Myriam Schweingruber.
> 
> 
> Bugs: 332811
>     https://bugs.kde.org/show_bug.cgi?id=332811
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Short bug description:
> Basically for m4a/mp4 files the tag is inserted but it's not recognized if the tool runs again. So the file is modified and a possibly-new tag is rewritten.
> 
> Please see bug tracking for more information.
> 
> 
> Diffs
> -----
> 
>   utilities/afttagger/AFTTagger.cpp 5a60c6b 
> 
> Diff: https://git.reviewboard.kde.org/r/117580/diff/
> 
> 
> Testing
> -------
> 
> Tested myself on the same installation on which I could reproduce the bug.
> 
> Thank you,
> Stefano
> 
> INFO: Processing file /home/xxx/Music/Test/Code 64/2003 - Storm/12 - Reaktor (Original mix).m4a
> INFO: Temporary file is at /home/xxx/Music/Test/Code 64/2003 - Storm/12 - Reaktor (Original mix).m4a.amarok-afttaggertemp.pid-20234.random-xrczmmvk.m4a
> INFO: File is a MP4 file, opening...
> INFO: Found an existing AFT identifier: ----:com.apple.iTunes:Amarok 2 AFTv1 - amarok.kde.org
> INFO: AFT identifier is version 1
> INFO: ID is current
> INFO: Cleaning up...
> INFO: Processing file /home/xxx/Music/Test/Code 64/2003 - Storm/13 - Without You (Zprochek mix).m4a
> INFO: Temporary file is at /home/xxx/Music/Test/Code 64/2003 - Storm/13 - Without You (Zprochek mix).m4a.amarok-afttaggertemp.pid-20234.random-fbNJp3UM.m4a
> INFO: File is a MP4 file, opening...
> INFO: Found an existing AFT identifier: ----:com.apple.iTunes:Amarok 2 AFTv1 - amarok.kde.org
> INFO: AFT identifier is version 1
> INFO: ID is current
> INFO: Cleaning up...
> INFO: Processing file /home/xxx/Music/Test/Code 64/2003 - Storm/14 - Without You (Spektron mix).m4a
> INFO: Temporary file is at /home/xxx/Music/Test/Code 64/2003 - Storm/14 - Without You (Spektron mix).m4a.amarok-afttaggertemp.pid-20234.random-OLe7wC54.m4a
> INFO: File is a MP4 file, opening...
> INFO: Found an existing AFT identifier: ----:com.apple.iTunes:Amarok 2 AFTv1 - amarok.kde.org
> INFO: AFT identifier is version 1
> INFO: ID is current
> INFO: Cleaning up...
> INFO: All done, exiting...
> 
> 
> Thanks,
> 
> Stefano Pettini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140508/6b1acd1f/attachment-0001.html>