Review Request 119509: Don't clear the playlist if amarok is playing on generating an APG

[Robert Marshall]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119509/
-----------------------------------------------------------

(Updated July 28, 2014, 8:33 a.m.)


Review request for Amarok.


Bugs: 305596
    https://bugs.kde.org/show_bug.cgi?id=305596


Repository: amarok


Description
-------

This is the small change I mentioned in a comment to bug 305596, where if amarok is playing I don't clear the playlist. I'd guess this is contentious, to justify it:
- With the pre-diff behaviour when a track is playing that track disappears from the current playlist on generating an APG but the track continues playing, this seems unexpected
- If Dynamic mode is enabled, then generating an APG - as a side effect of clearing the playlist - turns this off. With my change this doesn't happen.
- It also gives a way of supplying the wishlist detailed in bug 305596
This change introduces an extra .h dependency to Preset.cpp, I'm assuming that cmake will detect this and keep the build consistent.
If amarok is stopped then the behaviour is the same as at present - the playlist is cleared.


Diffs
-----

  src/playlistgenerator/Preset.cpp f670647 

Diff: https://git.reviewboard.kde.org/r/119509/diff/


Testing
-------

Built
Tested with generation of APGs both amarok stopped and playing tracks. I've used this change for 6+months without any problems


Thanks,

Robert Marshall

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140728/df19e16a/attachment.html>