Review Request 115154: Analyzer applet ASCII visualizer

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115154/#review63181
-----------------------------------------------------------

Ship it!


Hello Matej, only yesterday I saw your patch and immediately tried it out. So sorry for not replying earlier! Somehow I had missed this patch completely.

I quite like the idea of an ASCII visualization. It's simple and does not distract too much. The code is also fine, I don't see any issues with it. So I would like to see it in git master.

Shall we commit this patch for you, or do you have commit rights for the KDE git repo?

- Mark Kretschmann


On Jan. 20, 2014, 4:04 p.m., Matej Repinc wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115154/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2014, 4:04 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> ASCII visualization is an extension of the Analyzer applet, inspired by Asciiquarium screensaver. It's based on Blocky visualization.
> 
> 
> Diffs
> -----
> 
>   src/context/applets/analyzer/ASCIIAnalyzer.h PRE-CREATION 
>   src/context/applets/analyzer/ASCIIAnalyzer.cpp PRE-CREATION 
>   src/context/applets/analyzer/AnalyzerApplet.cpp 5af5819 
>   src/context/applets/analyzer/CMakeLists.txt 9fc5b30 
> 
> Diff: https://git.reviewboard.kde.org/r/115154/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matej Repinc
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140726/64c5cafb/attachment.html>