Review Request 118864: Don't prompt the user if the directories are not empty when moving tracks to trash

[Robert Marshall]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118864/
-----------------------------------------------------------

(Updated July 24, 2014, 4:13 p.m.)


Review request for Amarok.


Changes
-------

cleaned up code to conform with project style, added comment!


Repository: amarok


Description
-------

If the user hasn't turned off the dialog which notifies if they want directories deleting they get prompted even if the directory is not empty. amarok ought to only prompt when it needs the information. Maybe I should select the don't prompt in future option but I prefer to know what's going on!


Diffs (updated)
-----

  src/core/collections/CollectionLocation.cpp 209d6b4 

Diff: https://git.reviewboard.kde.org/r/118864/diff/


Testing
-------

Built
Tested deleting tracks on  empty directories - prompted
Tested directories containing music and just containing other files - not prompted

Do I need a bug/enhancement report to tie to this?

I wondered whether this change might be inefficient if the collection has many levels but seems to be ok at least with my testing.


Thanks,

Robert Marshall

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140724/7d27ff68/attachment.html>