Review Request 113876: Linking error in newly created files

[Vedant Agarwala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113876/
-----------------------------------------------------------

(Updated Jan. 24, 2014, 8:57 a.m.)


Review request for Amarok.


Changes
-------

I have installed FFMPEG. So now code requiring libOFA is also compiling (like tagguessing/musicbrainz/MusicDNSFinder.cpp,MusicDNSXmlParser.cpp).
Some more code changes but the main issue is the same


Repository: amarok


Description (updated)
-------

I am stuck at these undefined reference errors: http://pastebin.kde.org/prhb9jj2r
Basically the MusicBrainzFiner class inherits the TagGuessing::Provider class. I tried to create a new Tagguessing library but it would always lead to "cyclic dependencies" while running cmake.
Finally I added all the tagguessing classes (i.e. the classes in dir "tagguessing" and its sub dirs) to amaroklib. Even then I am getting the linking errors. I added the AMAROK_EXPORT macro to these classes but still the same error was being produced so I reverted.


Diffs (updated)
-----

  CMakeLists.txt 4ffee3a 
  ChangeLog 0eb03c8 
  cmake/modules/FindLibChromaprint.cmake PRE-CREATION 
  shared/collectionscanner/ScanningState.h ad9e03b 
  shared/collectionscanner/ScanningState.cpp 488b5ec 
  shared/tag_helpers/VorbisCommentTagHelper.cpp f3ff542 
  src/CMakeLists.txt 70fb67b 
  src/context/applets/analyzer/BlockAnalyzer.h df0506b 
  src/context/applets/analyzer/BlockAnalyzer.cpp 6325774 
  src/core/transcoding/TranscodingConfiguration.cpp 327937c 
  src/core/transcoding/formats/TranscodingOpusFormat.cpp c0062c7 
  src/dialogs/MusicBrainzTagger.h bef0621 
  src/dialogs/MusicBrainzTagger.cpp 591f087 
  src/dialogs/MusicBrainzTagger.ui 156f8d3 
  src/dialogs/TagDialog.h 626f903 
  src/dialogs/TagDialog.cpp 48aadd9 
  src/dialogs/TagDialogBase.ui 7ed36ea 
  src/dialogs/WebServicesTagger.ui PRE-CREATION 
  src/dialogs/WebServicesTaggerDialog.h PRE-CREATION 
  src/dialogs/WebServicesTaggerDialog.cpp PRE-CREATION 
  src/musicbrainz/MusicBrainzFinder.h beb1551 
  src/musicbrainz/MusicBrainzFinder.cpp 9a1b3bb 
  src/musicbrainz/MusicBrainzMeta.h 6e21232 
  src/musicbrainz/MusicBrainzTagsItem.h 6852c9f 
  src/musicbrainz/MusicBrainzTagsItem.cpp 0941a90 
  src/musicbrainz/MusicBrainzTagsModel.h eaee7f8 
  src/musicbrainz/MusicBrainzTagsModel.cpp 0ffb284 
  src/musicbrainz/MusicBrainzTagsModelDelegate.h d276af7 
  src/musicbrainz/MusicBrainzTagsModelDelegate.cpp a11c9c3 
  src/musicbrainz/MusicBrainzTagsView.h 6997e34 
  src/musicbrainz/MusicBrainzTagsView.cpp 96cbd17 
  src/musicbrainz/MusicBrainzXmlParser.h c7f9e72 
  src/musicbrainz/MusicBrainzXmlParser.cpp 290a275 
  src/musicbrainz/MusicDNSAudioDecoder.h ca98c20 
  src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b 
  src/musicbrainz/MusicDNSFinder.h 90c4c9c 
  src/musicbrainz/MusicDNSFinder.cpp d393211 
  src/musicbrainz/MusicDNSXmlParser.h 982861d 
  src/musicbrainz/MusicDNSXmlParser.cpp 1f3f54f 
  src/playback/Fadeouter.h 798189e 
  src/playback/Fadeouter.cpp 74b535e 
  src/scripts/librivox_service/script.desktop 1b12346 
  src/scripts/lyrics_lyricwiki/script.desktop a309614 
  src/scripts/radio_station_service/script.desktop ba64a46 
  src/scripts/script_console/script.desktop cc062e0 
  src/tagguessing/AudioToQStringDecoder.h PRE-CREATION 
  src/tagguessing/AudioToQStringDecoder.cpp PRE-CREATION 
  src/tagguessing/Finder.h PRE-CREATION 
  src/tagguessing/Finder.cpp PRE-CREATION 
  src/tagguessing/Meta.h PRE-CREATION 
  src/tagguessing/Provider.h PRE-CREATION 
  src/tagguessing/Provider.cpp PRE-CREATION 
  src/tagguessing/TagsItem.h PRE-CREATION 
  src/tagguessing/TagsItem.cpp PRE-CREATION 
  src/tagguessing/TagsModel.h PRE-CREATION 
  src/tagguessing/TagsModel.cpp PRE-CREATION 
  src/tagguessing/TagsModelDelegate.h PRE-CREATION 
  src/tagguessing/TagsModelDelegate.cpp PRE-CREATION 
  src/tagguessing/TagsView.h PRE-CREATION 
  src/tagguessing/TagsView.cpp PRE-CREATION 
  src/tagguessing/WebRequestsHandler.h PRE-CREATION 
  src/tagguessing/WebRequestsHandler.cpp PRE-CREATION 
  src/tagguessing/acoustid/AcoustIdProvider.h PRE-CREATION 
  src/tagguessing/acoustid/AcoustIdProvider.cpp PRE-CREATION 
  src/tagguessing/acoustid/FingerprintCalculator.h PRE-CREATION 
  src/tagguessing/acoustid/FingerprintCalculator.cpp PRE-CREATION 
  src/tagguessing/acoustid/WebserviceQueryer.h PRE-CREATION 
  src/tagguessing/acoustid/WebserviceQueryer.cpp PRE-CREATION 
  src/tagguessing/musicbrainz/MusicBrainzFinder.h PRE-CREATION 
  src/tagguessing/musicbrainz/MusicBrainzFinder.cpp PRE-CREATION 
  src/tagguessing/musicbrainz/MusicBrainzXmlParser.h PRE-CREATION 
  src/tagguessing/musicbrainz/MusicBrainzXmlParser.cpp PRE-CREATION 
  src/tagguessing/musicbrainz/MusicDNSFinder.h PRE-CREATION 
  src/tagguessing/musicbrainz/MusicDNSFinder.cpp PRE-CREATION 
  src/tagguessing/musicbrainz/MusicDNSXmlParser.h PRE-CREATION 
  src/tagguessing/musicbrainz/MusicDNSXmlParser.cpp PRE-CREATION 
  tests/core/collections/MockCollectionLocationDelegate.h a2f4504 
  tests/mocks/MockTrack.h fec6ef2 
  utilities/collectionscanner/CollectionScanner.cpp a001115 

Diff: https://git.reviewboard.kde.org/r/113876/diff/


Testing
-------


Thanks,

Vedant Agarwala

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20140124/145e724b/attachment.html>