<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113876/">https://git.reviewboard.kde.org/r/113876/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Vedant Agarwala.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2014, 8:57 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have installed FFMPEG. So now code requiring libOFA is also compiling (like tagguessing/musicbrainz/MusicDNSFinder.cpp,MusicDNSXmlParser.cpp).
Some more code changes but the main issue is the same</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am stuck at these undefined reference errors: http://pastebin.kde.org/prhb9jj2r
Basically the MusicBrainzFiner class inherits the TagGuessing::Provider class. I tried to create a new Tagguessing library but it would always lead to "cyclic dependencies" while running cmake.
Finally I added all the tagguessing classes (i.e. the classes in dir "tagguessing" and its sub dirs) to amaroklib. Even then I am getting the linking errors. I added the AMAROK_EXPORT macro to these classes but still the same error was being produced so I reverted.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4ffee3a)</span></li>
<li>ChangeLog <span style="color: grey">(0eb03c8)</span></li>
<li>cmake/modules/FindLibChromaprint.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/collectionscanner/ScanningState.h <span style="color: grey">(ad9e03b)</span></li>
<li>shared/collectionscanner/ScanningState.cpp <span style="color: grey">(488b5ec)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: grey">(f3ff542)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(70fb67b)</span></li>
<li>src/context/applets/analyzer/BlockAnalyzer.h <span style="color: grey">(df0506b)</span></li>
<li>src/context/applets/analyzer/BlockAnalyzer.cpp <span style="color: grey">(6325774)</span></li>
<li>src/core/transcoding/TranscodingConfiguration.cpp <span style="color: grey">(327937c)</span></li>
<li>src/core/transcoding/formats/TranscodingOpusFormat.cpp <span style="color: grey">(c0062c7)</span></li>
<li>src/dialogs/MusicBrainzTagger.h <span style="color: grey">(bef0621)</span></li>
<li>src/dialogs/MusicBrainzTagger.cpp <span style="color: grey">(591f087)</span></li>
<li>src/dialogs/MusicBrainzTagger.ui <span style="color: grey">(156f8d3)</span></li>
<li>src/dialogs/TagDialog.h <span style="color: grey">(626f903)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(48aadd9)</span></li>
<li>src/dialogs/TagDialogBase.ui <span style="color: grey">(7ed36ea)</span></li>
<li>src/dialogs/WebServicesTagger.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/dialogs/WebServicesTaggerDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/dialogs/WebServicesTaggerDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.h <span style="color: grey">(beb1551)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey">(9a1b3bb)</span></li>
<li>src/musicbrainz/MusicBrainzMeta.h <span style="color: grey">(6e21232)</span></li>
<li>src/musicbrainz/MusicBrainzTagsItem.h <span style="color: grey">(6852c9f)</span></li>
<li>src/musicbrainz/MusicBrainzTagsItem.cpp <span style="color: grey">(0941a90)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.h <span style="color: grey">(eaee7f8)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.cpp <span style="color: grey">(0ffb284)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModelDelegate.h <span style="color: grey">(d276af7)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModelDelegate.cpp <span style="color: grey">(a11c9c3)</span></li>
<li>src/musicbrainz/MusicBrainzTagsView.h <span style="color: grey">(6997e34)</span></li>
<li>src/musicbrainz/MusicBrainzTagsView.cpp <span style="color: grey">(96cbd17)</span></li>
<li>src/musicbrainz/MusicBrainzXmlParser.h <span style="color: grey">(c7f9e72)</span></li>
<li>src/musicbrainz/MusicBrainzXmlParser.cpp <span style="color: grey">(290a275)</span></li>
<li>src/musicbrainz/MusicDNSAudioDecoder.h <span style="color: grey">(ca98c20)</span></li>
<li>src/musicbrainz/MusicDNSAudioDecoder.cpp <span style="color: grey">(ea39a1b)</span></li>
<li>src/musicbrainz/MusicDNSFinder.h <span style="color: grey">(90c4c9c)</span></li>
<li>src/musicbrainz/MusicDNSFinder.cpp <span style="color: grey">(d393211)</span></li>
<li>src/musicbrainz/MusicDNSXmlParser.h <span style="color: grey">(982861d)</span></li>
<li>src/musicbrainz/MusicDNSXmlParser.cpp <span style="color: grey">(1f3f54f)</span></li>
<li>src/playback/Fadeouter.h <span style="color: grey">(798189e)</span></li>
<li>src/playback/Fadeouter.cpp <span style="color: grey">(74b535e)</span></li>
<li>src/scripts/librivox_service/script.desktop <span style="color: grey">(1b12346)</span></li>
<li>src/scripts/lyrics_lyricwiki/script.desktop <span style="color: grey">(a309614)</span></li>
<li>src/scripts/radio_station_service/script.desktop <span style="color: grey">(ba64a46)</span></li>
<li>src/scripts/script_console/script.desktop <span style="color: grey">(cc062e0)</span></li>
<li>src/tagguessing/AudioToQStringDecoder.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/AudioToQStringDecoder.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/Finder.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/Finder.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/Meta.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/Provider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/Provider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsModelDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsModelDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/WebRequestsHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/WebRequestsHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acoustid/AcoustIdProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acoustid/AcoustIdProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acoustid/FingerprintCalculator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acoustid/FingerprintCalculator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acoustid/WebserviceQueryer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acoustid/WebserviceQueryer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicBrainzFinder.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicBrainzXmlParser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicBrainzXmlParser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicDNSFinder.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicDNSFinder.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicDNSXmlParser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicDNSXmlParser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/core/collections/MockCollectionLocationDelegate.h <span style="color: grey">(a2f4504)</span></li>
<li>tests/mocks/MockTrack.h <span style="color: grey">(fec6ef2)</span></li>
<li>utilities/collectionscanner/CollectionScanner.cpp <span style="color: grey">(a001115)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113876/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>