Review Request 112551: Patch to only guess album from directory if album, album artist, track title and track artist is missing

Mathias Dietrich dietrichmathias at gmail.com
Fri Sep 6 09:00:16 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112551/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

This patch has quite a long history.
Patch for improved album guessing, refering to our discussion on amarok-devel, starting here: http://mail.kde.org/pipermail/amarok-devel/2013-July/012413.html

Unfortunately I got no feedback from other developer except from Mat?j Laitl, so I just hacked it :)

Feedback welcome as it is my first Amarok contribution.


This addresses bug 322185.
    https://bugs.kde.org/show_bug.cgi?id=322185


Diffs
-----

  src/scanner/AbstractScanResultProcessor.cpp 937924b 

Diff: http://git.reviewboard.kde.org/r/112551/diff/


Testing
-------

Tested on Amarok git.
Works fine here.


Thanks,

Mathias Dietrich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130906/1343c8b5/attachment.html>


More information about the Amarok-devel mailing list