Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

[Konrad Zemek]

> On Oct. 17, 2013, 2:27 p.m., Edward Hades Toroshchin wrote:
> > Music, lines 11-12
> > <http://git.reviewboard.kde.org/r/113277/diff/1/?file=202043#file202043line11>
> >
> >     Probably you should remove private data, like directory path and library ID.

I don't really care about the data; it's a vanilla iTunes installation on a dedicated, vanilla WinXP VM. I wanted to leave the XML mostly intact just in case something in there might cause parser to fail. Or should I remove it for some other reason?


- Konrad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113277/#review41889
-----------------------------------------------------------


On Oct. 21, 2013, 4:37 p.m., Konrad Zemek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113277/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2013, 4:37 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> This review contains importers tests.
> 
> The tests/importers/TestImporterBase.cpp contains common tests for concrete
> importers. The tests load a prepared database and read it through the importer.
> It's therefore important that the prepared database contain certain data.
> The tests/importers/files/testCollection directory contains very small mp3
> files that are *not* used as a part of the tests, and instead are meant for
> creating the test database: one would just import these files into a media
> player, copy the media player's database and have it instantly ready for
> the common tests.
> 
> 
> Diffs
> -----
> 
>   tests/importers/ImporterMocks.h PRE-CREATION 
>   tests/importers/TestImporterManager.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113277/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Konrad Zemek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131021/68928983/attachment.html>