Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

[Konrad Zemek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113277/
-----------------------------------------------------------

(Updated Oct. 21, 2013, 4:37 p.m.)


Review request for Amarok.


Repository: amarok


Description
-------

This review contains importers tests.

The tests/importers/TestImporterBase.cpp contains common tests for concrete
importers. The tests load a prepared database and read it through the importer.
It's therefore important that the prepared database contain certain data.
The tests/importers/files/testCollection directory contains very small mp3
files that are *not* used as a part of the tests, and instead are meant for
creating the test database: one would just import these files into a media
player, copy the media player's database and have it instantly ready for
the common tests.


Diffs (updated)
-----

  tests/importers/ImporterMocks.h PRE-CREATION 
  tests/importers/TestImporterManager.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113277/diff/


Testing
-------


Thanks,

Konrad Zemek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131021/29e34636/attachment.html>