Review Request 113346: BugFix: 317902 - Issue a warning when transcoding is not possible

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113346/#review41982
-----------------------------------------------------------


Hi, thanks for the patch. It certainly goes in the right direction, but it could be simplified in order not to touch the API that much. Also please attach here a screenshot of the dialog with the next version of this patch.


src/core-impl/collections/support/CollectionLocationDelegateImpl.h
<http://git.reviewboard.kde.org/r/113346/#comment30633>

    TranscodingAssistantDialog knows what encoders are available (see its populateFormatList() method), no need to pass this as an argument. Also, please mind Amarok coding style (space between "transcode(" and "const")



src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp
<http://git.reviewboard.kde.org/r/113346/#comment30634>

    ditto TranscodingAssistantDialog knows.



src/core/collections/CollectionLocation.cpp
<http://git.reviewboard.kde.org/r/113346/#comment30635>

    ditto TranscodingAssistantDialog knows.



src/core/collections/CollectionLocation.cpp
<http://git.reviewboard.kde.org/r/113346/#comment30636>

    ditto TranscodingAssistantDialog knows.



src/core/collections/CollectionLocationDelegate.h
<http://git.reviewboard.kde.org/r/113346/#comment30637>

    ditto TranscodingAssistantDialog knows.



src/transcoding/TranscodingAssistantDialog.h
<http://git.reviewboard.kde.org/r/113346/#comment30640>

    ditto TranscodingAssistantDialog knows.



src/transcoding/TranscodingAssistantDialog.ui
<http://git.reviewboard.kde.org/r/113346/#comment30638>

    No need to specify default properties, please use the "reset" button in Qt Designer to make it default (non-bold in Qt Designer UI)



src/transcoding/TranscodingAssistantDialog.ui
<http://git.reviewboard.kde.org/r/113346/#comment30639>

    The text could be even more helpful, i.e. tell user what she needs to install (ffmpeg or libav with ffmpeg wrapper).


- Matěj Laitl


On Oct. 19, 2013, 11:12 a.m., Jai  Luthra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113346/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2013, 11:12 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 317902
>     https://bugs.kde.org/show_bug.cgi?id=317902
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> When ffmpeg is not available, the transcoding dialog will not be skipped; rather it will add a note for the user to install an encoder.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/support/CollectionLocationDelegateImpl.h 9d90580 
>   src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp 14fd251 
>   src/core/collections/CollectionLocation.cpp 2385570 
>   src/core/collections/CollectionLocationDelegate.h 3c80d07 
>   src/transcoding/TranscodingAssistantDialog.h 0acb701 
>   src/transcoding/TranscodingAssistantDialog.cpp 17fc250 
>   src/transcoding/TranscodingAssistantDialog.ui 0ad83b2 
> 
> Diff: http://git.reviewboard.kde.org/r/113346/diff/
> 
> 
> Testing
> -------
> 
> * Compiles
> * Works as expected
> 
> 
> Thanks,
> 
> Jai  Luthra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131019/f3e89fe8/attachment-0001.html>