Review Request 113346: BugFix: 317902 - Issue a warning when transcoding is not possible

[Jai Luthra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113346/
-----------------------------------------------------------

(Updated Oct. 19, 2013, 9:12 a.m.)


Review request for Amarok.


Changes
-------

* QLabel::encoderNotFound => QLabel::encoderNotFoundLabel
* First checks if encoder is available, as that is the case most of the time.
* Use true-false instead of 1 and 0


Bugs: 317902
    https://bugs.kde.org/show_bug.cgi?id=317902


Repository: amarok


Description
-------

When ffmpeg is not available, the transcoding dialog will not be skipped; rather it will add a note for the user to install an encoder.


Diffs (updated)
-----

  src/core-impl/collections/support/CollectionLocationDelegateImpl.h 9d90580 
  src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp 14fd251 
  src/core/collections/CollectionLocation.cpp 2385570 
  src/core/collections/CollectionLocationDelegate.h 3c80d07 
  src/transcoding/TranscodingAssistantDialog.h 0acb701 
  src/transcoding/TranscodingAssistantDialog.cpp 17fc250 
  src/transcoding/TranscodingAssistantDialog.ui 0ad83b2 

Diff: http://git.reviewboard.kde.org/r/113346/diff/


Testing
-------

* Compiles
* Works as expected


Thanks,

Jai  Luthra

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131019/fba1bdd3/attachment-0001.html>