Review Request 113278: GSoC 2013 - Advanced Importers - 4/4: Other changes in the repository

[Edward Hades Toroshchin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113278/#review41887
-----------------------------------------------------------



src/core/support/PluginFactory.h
<http://git.reviewboard.kde.org/r/113278/#comment30570>

    I would probably add the "Importer" to the end, just for the off-chance someone attempts to load an old library with old type id.
    
    Don't know if it sounds important, just wanted to point out.


- Edward Hades Toroshchin


On Oct. 16, 2013, 5:11 p.m., Konrad Zemek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113278/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 5:11 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> This review contains other changes made as a part of my project, i.e. changes
> outside of src/statsyncing , src/importers and tests/importers directories.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 70fb67b420bd0351a4b798bcf70d14faa14a4ccc 
>   src/PluginManager.cpp c48a99be838a4d2c36484e5785f37473797dedec 
>   src/configdialog/dialogs/MetadataConfig.h 72ef69bac718a13432cc662c72cc0c2577753bb9 
>   src/configdialog/dialogs/MetadataConfig.cpp 7d19f9352909eb514e4f5d0cd544c913a0a36207 
>   src/configdialog/dialogs/MetadataConfig.ui ff5d332f79c53aef9c26c0e1afd6999707a74c78 
>   src/configdialog/dialogs/PluginsConfig.cpp d5011b80ec3899b99aeb18fbd4b77f059120bb5e 
>   src/core-impl/collections/support/CollectionManager.h 062418c087c1baf612ef98ee52f5b0f30d24964b 
>   src/core/support/PluginFactory.h 8acd354bd4581eb319c4df34d0433eba247722f0 
>   src/dialogs/CollectionSetup.cpp 2b120e3cdc9337c472543d3480b6a2b7eaa4de72 
>   src/dialogs/DatabaseImporterDialog.h f0ae7c34b5c1c9c97b666b533c3d74fcfeadca10 
>   src/dialogs/DatabaseImporterDialog.cpp 5159ce8376a7853b8e6f0471502e86a5e339f153 
>   src/services/lastfm/SynchronizationTrack.h d6fb593e9a4e7e657ccffd7df1c4193167d0e95e 
>   src/services/lastfm/SynchronizationTrack.cpp 39c51d4fe935a06ee9be8dbddc1997c61bf5ec84 
>   tests/CMakeLists.txt e18aaa16be31e437d98685a2f0ce059bcd7ecb3e 
>   tests/CollectionTestImpl.h 183c3c2d4549b28d77221e0a928135c858b579e2 
>   tests/mocks/MetaMock.h 37a50cebbe1f148a0280f93a63f496e67b8e1601 
> 
> Diff: http://git.reviewboard.kde.org/r/113278/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Konrad Zemek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131017/78a1664e/attachment.html>