<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113278/">http://git.reviewboard.kde.org/r/113278/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113278/diff/1/?file=202202#file202202line36" style="color: black; font-weight: bold; text-decoration: underline;">src/core/support/PluginFactory.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class AMAROK_CORE_EXPORT PluginFactory : public QObject</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">36</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">enum</span> <span class="n">Type</span> <span class="p">{</span> <span class="n">Unknown</span><span class="p">,</span> <span class="n">Collection</span><span class="p">,</span> <span class="n">Service</span> <span class="p">};</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">36</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">enum</span> <span class="n">Type</span> <span class="p">{</span> <span class="n">Unknown</span><span class="p">,</span> <span class="n">Collection</span><span class="p">,</span> <span class="n"><span class="hl">Importer</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n">Service</span> <span class="p">};</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would probably add the "Importer" to the end, just for the off-chance someone attempts to load an old library with old type id.
Don't know if it sounds important, just wanted to point out.</pre>
</div>
<br />
<p>- Edward Hades Toroshchin</p>
<br />
<p>On October 16th, 2013, 5:11 p.m. UTC, Konrad Zemek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Konrad Zemek.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2013, 5:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review contains other changes made as a part of my project, i.e. changes
outside of src/statsyncing , src/importers and tests/importers directories.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(70fb67b420bd0351a4b798bcf70d14faa14a4ccc)</span></li>
<li>src/PluginManager.cpp <span style="color: grey">(c48a99be838a4d2c36484e5785f37473797dedec)</span></li>
<li>src/configdialog/dialogs/MetadataConfig.h <span style="color: grey">(72ef69bac718a13432cc662c72cc0c2577753bb9)</span></li>
<li>src/configdialog/dialogs/MetadataConfig.cpp <span style="color: grey">(7d19f9352909eb514e4f5d0cd544c913a0a36207)</span></li>
<li>src/configdialog/dialogs/MetadataConfig.ui <span style="color: grey">(ff5d332f79c53aef9c26c0e1afd6999707a74c78)</span></li>
<li>src/configdialog/dialogs/PluginsConfig.cpp <span style="color: grey">(d5011b80ec3899b99aeb18fbd4b77f059120bb5e)</span></li>
<li>src/core-impl/collections/support/CollectionManager.h <span style="color: grey">(062418c087c1baf612ef98ee52f5b0f30d24964b)</span></li>
<li>src/core/support/PluginFactory.h <span style="color: grey">(8acd354bd4581eb319c4df34d0433eba247722f0)</span></li>
<li>src/dialogs/CollectionSetup.cpp <span style="color: grey">(2b120e3cdc9337c472543d3480b6a2b7eaa4de72)</span></li>
<li>src/dialogs/DatabaseImporterDialog.h <span style="color: grey">(f0ae7c34b5c1c9c97b666b533c3d74fcfeadca10)</span></li>
<li>src/dialogs/DatabaseImporterDialog.cpp <span style="color: grey">(5159ce8376a7853b8e6f0471502e86a5e339f153)</span></li>
<li>src/services/lastfm/SynchronizationTrack.h <span style="color: grey">(d6fb593e9a4e7e657ccffd7df1c4193167d0e95e)</span></li>
<li>src/services/lastfm/SynchronizationTrack.cpp <span style="color: grey">(39c51d4fe935a06ee9be8dbddc1997c61bf5ec84)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(e18aaa16be31e437d98685a2f0ce059bcd7ecb3e)</span></li>
<li>tests/CollectionTestImpl.h <span style="color: grey">(183c3c2d4549b28d77221e0a928135c858b579e2)</span></li>
<li>tests/mocks/MetaMock.h <span style="color: grey">(37a50cebbe1f148a0280f93a63f496e67b8e1601)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113278/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>