Review Request 110520: create new collections without restart

[Edward Hades Toroshchin]

> On May 20, 2013, 8:18 a.m., Mark Kretschmann wrote:
> > This works nicely. To make it complete, could we also remove collections immediately when the plugin is being disabled?

I'm not even sure if any collection can be removed safely. The removable devices' collections probably can, but that's probably it.


- Edward Hades


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110520/#review32797
-----------------------------------------------------------


On May 19, 2013, 8:43 a.m., Edward Hades Toroshchin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110520/
> -----------------------------------------------------------
> 
> (Updated May 19, 2013, 8:43 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> create new collections without restart
> 
> 
> Diffs
> -----
> 
>   src/PluginManager.cpp fc825cece9d06a92a9a84a1dcfa949bfc6c14ed8 
>   src/core-impl/collections/support/CollectionManager.h a3cb6cefc958fb2875c7bef075f4a5319fc8b958 
>   src/core-impl/collections/support/CollectionManager.cpp 0775206655b47d660c92bf6ebf23623de356bb69 
> 
> Diff: http://git.reviewboard.kde.org/r/110520/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Edward Hades Toroshchin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130520/6aa046d1/attachment.html>