Review Request 110520: create new collections without restart

Mark Kretschmann kretschmann at kde.org
Mon May 20 08:18:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110520/#review32797
-----------------------------------------------------------


This works nicely. To make it complete, could we also remove collections immediately when the plugin is being disabled?

- Mark Kretschmann


On May 19, 2013, 8:43 a.m., Edward Hades Toroshchin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110520/
> -----------------------------------------------------------
> 
> (Updated May 19, 2013, 8:43 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> create new collections without restart
> 
> 
> Diffs
> -----
> 
>   src/PluginManager.cpp fc825cece9d06a92a9a84a1dcfa949bfc6c14ed8 
>   src/core-impl/collections/support/CollectionManager.h a3cb6cefc958fb2875c7bef075f4a5319fc8b958 
>   src/core-impl/collections/support/CollectionManager.cpp 0775206655b47d660c92bf6ebf23623de356bb69 
> 
> Diff: http://git.reviewboard.kde.org/r/110520/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Edward Hades Toroshchin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130520/a80389fc/attachment.html>


More information about the Amarok-devel mailing list