Review Request 110101: fixes Bug 242256 - JJ: Make Magnatue service use KWallet for password storage

[vedant agarwala]

Hello,
I need help in editing the cmakelists.txt.
I have created a KWalletHelper.h|cpp in the "src/services" directory. I
added the KWalletHelper.cpp to the src/cmakelists.txt (inside "set" of
SERVICEFRAMWORK). The class is compiling but then throwing linking errors
during link-time. I edited the src/services/magnatune/cmakelists.txt to add
it to the "target_link_libraries" but no avail. I think I am doing it wrong
here.
Any help would be greatly appreciated.
Thanking-you,
Vedant


On Sat, Apr 27, 2013 at 4:17 PM, vedant agarwala <vedant.kota at gmail.com>wrote:

> Hello,
> Seems like this is turning out to be an important feature. Surely now I
> will change the GpodderServicer code to connect to the "KWalletHelper"
> class in my upcoming review request.
>
> Regards,
> Vedant.
>
>
>
> On Sat, Apr 27, 2013 at 3:52 PM, Stefan Derkits <stefan at derkits.at> wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi,
>>
>> On 04/27/2013 11:45 AM, Vedant Agarwala wrote:
>> > I agree. I will upload another patch making changes to both last.fm
>> > and magnatune code. I was thinking of a common helper class
>> > complete with the "no KWallet found dialog". Tell me any other
>> > specifics that should be a part of this KWalletHelper class.
>>
>> a common KWallet Helper Class (if possible) sounds good, the
>> GpodderService uses KWallet code that at the time of the creation of
>> the code was more or less a copy of the last.fm Wallet Code. So maybe
>> the GpodderService could also be a Candidate for using this
>> KWalletHelper class ;)
>>
>> Greetings,
>> Stefan
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.12 (GNU/Linux)
>>
>> iEYEARECAAYFAlF7pssACgkQlZvAMV/NgGLEkQCgoai1Bi/PzZ4H6P1iNPQ4q42X
>> b3wAn1SsfeE/9ipouiiVLBtNFB9WDzUg
>> =5o1m
>> -----END PGP SIGNATURE-----
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130514/a6562548/attachment.html>