Review Request 110362: BR 317385 - Command line options like --queue and --append do not work

[Anmol Ahuja]

> On May 9, 2013, 11:41 p.m., Mark Kretschmann wrote:
> > Sorry, what does this patch have to do with the bug report? It doesn't fix the bug at all.
> > 
> > The command line argument issues are just a symptom of the underlying bug, see my comments in the report. I'm debugging this currently.
> 
> Anmol Ahuja wrote:
>     I'm sorry, it doesn't solve the complete problem.
>     
>     According to the bug report:
>     "Expected Results:
>     1) look for the actual song/url on the current playlist, or appending that song to the playlist if not found; and
>     2) queue that song"
>     
>     So I added a -unique argument, though it doesn't fix the broken append and play.
> 
> Matěj Laitl wrote:
>     > Sorry, what does this patch have to do with the bug report? It doesn't fix the bug at all.
>     
>     I don't agree with this, please read the original description of the bug again, Mark. This patch indeed could be the solution, however perhaps we just want a different one. The problem described is that --queue just inserts the track after the currently playing one, while it should use the Queue feature of our playlist instead. Anmol, feel free to update the patch to solve this point.
>     
>     The reporter also wanted that --queue wouldn't re-add (but just move) a track if it is already in the playlist - I don't think we want to implement this - it looks like the reporter wants to do fancy things with the command line where DBus interface or Scripting API should be used instead.
> 
> Matěj Laitl wrote:
>     I don't see "Reopen for review" button, Marok of Anmol, please hit it, this review shouldn't have been marked as discarded.
> 
> Anmol Ahuja wrote:
>     Okay.(Apparently, you're not notified of new comments on discarded requests.)
>     And should I keep the unique argument? There was already some unused code and an enum for it.
>

Matěj: ^


- Anmol


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110362/#review32287
-----------------------------------------------------------


On May 12, 2013, 6:54 p.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110362/
> -----------------------------------------------------------
> 
> (Updated May 12, 2013, 6:54 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Added -unique argument to Amarok command line options.
> 
> 
> Bug Report: https://bugs.kde.org/show_bug.cgi?id=317385
> 
> 
> This addresses bug 317385.
>     https://bugs.kde.org/show_bug.cgi?id=317385
> 
> 
> Diffs
> -----
> 
>   src/App.h 97dfdf2 
>   src/App.cpp 858d76d 
>   src/playlist/PlaylistActions.h 75b71fd 
>   src/playlist/PlaylistActions.cpp b36794d 
>   src/playlist/PlaylistModel.cpp c23de72 
> 
> Diff: http://git.reviewboard.kde.org/r/110362/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130512/908f76bd/attachment.html>