Review Request 110362: BR 317385 - Command line options like --queue and --append do not work

Mark Kretschmann kretschmann at kde.org
Thu May 9 18:11:00 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110362/#review32287
-----------------------------------------------------------


Sorry, what does this patch have to do with the bug report? It doesn't fix the bug at all.

The command line argument issues are just a symptom of the underlying bug, see my comments in the report. I'm debugging this currently.

- Mark Kretschmann


On May 9, 2013, 5:51 p.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110362/
> -----------------------------------------------------------
> 
> (Updated May 9, 2013, 5:51 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Added -unique argument to Amarok command line options.
> 
> 
> Bug Report: https://bugs.kde.org/show_bug.cgi?id=317385
> 
> 
> This addresses bug 317385.
>     https://bugs.kde.org/show_bug.cgi?id=317385
> 
> 
> Diffs
> -----
> 
>   src/App.h 97dfdf2 
>   src/App.cpp 858d76d 
>   src/playlist/PlaylistActions.h 75b71fd 
>   src/playlist/PlaylistActions.cpp b36794d 
>   src/playlist/PlaylistModel.cpp c23de72 
> 
> Diff: http://git.reviewboard.kde.org/r/110362/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130509/375b1bf1/attachment.html>


More information about the Amarok-devel mailing list