Review Request 109224: Patch for bug 315932 in Amarok. Resolving the window not coming up on launching the second time in Amarok.

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109224/#review28595
-----------------------------------------------------------


I think this breaks "Click on mp3 file in Dolphin to have it open in Amarok", %U may be also needed to signify that Amarok understands remote urls (as opposed to %u). Harikrishnan, can you please test this? There might be some work-arounds, but please study and quote .desktop file standard on freedesktop.org to actually understand what you change.

P.S.: Fabian, special thanks for testing this out, this is really valuable as it catches initial problems with submitted patches which in turn means Amarok devs have more time to actually hack which in turn means better Amarok! I encourage you to test the above point and to test other Amarok review requests as you see fit.

- Matěj Laitl


On March 2, 2013, 3:19 p.m., Harikrishnan S. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109224/
> -----------------------------------------------------------
> 
> (Updated March 2, 2013, 3:19 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Resolved bug:315932 found at https://bugs.kde.org/show_bug.cgi?id=315932
> Removed %U from amarok.desktop found at /src/amarok/src
> 
> 
> Diffs
> -----
> 
>   src/amarok.desktop 4fe72c0d96111f2bd8bdea3e12622e09320ad31c 
> 
> Diff: http://git.reviewboard.kde.org/r/109224/diff/
> 
> 
> Testing
> -------
> 
> Seems to be working. On launching the second time, the window does come up now. Also build perfectly.
> 
> 
> Thanks,
> 
> Harikrishnan S.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130305/c60a8c57/attachment.html>