<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109224/">http://git.reviewboard.kde.org/r/109224/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this breaks "Click on mp3 file in Dolphin to have it open in Amarok", %U may be also needed to signify that Amarok understands remote urls (as opposed to %u). Harikrishnan, can you please test this? There might be some work-arounds, but please study and quote .desktop file standard on freedesktop.org to actually understand what you change.
P.S.: Fabian, special thanks for testing this out, this is really valuable as it catches initial problems with submitted patches which in turn means Amarok devs have more time to actually hack which in turn means better Amarok! I encourage you to test the above point and to test other Amarok review requests as you see fit.</pre>
<br />
<p>- Matěj</p>
<br />
<p>On March 2nd, 2013, 3:19 p.m. UTC, Harikrishnan S. wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Harikrishnan S..</div>
<p style="color: grey;"><i>Updated March 2, 2013, 3:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Resolved bug:315932 found at https://bugs.kde.org/show_bug.cgi?id=315932
Removed %U from amarok.desktop found at /src/amarok/src</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems to be working. On launching the second time, the window does come up now. Also build perfectly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/amarok.desktop <span style="color: grey">(4fe72c0d96111f2bd8bdea3e12622e09320ad31c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109224/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>