Review Request 111275: putting Artist - Title of the current track to the clipboard using a shortcut

[fleissig fleissig]

> On June 28, 2013, 5:05 p.m., Matěj Laitl wrote:
> > src/MainWindow.cpp, line 725
> > <http://git.reviewboard.kde.org/r/111275/diff/1/?file=166263#file166263line725>
> >
> >     I suggest safety against artist() being null. Note that:
> >     if( ...->artist() )
> >         ...->artist()->...
> >     
> >     is unsafe, you need a temporary.

I've added a check, but even a song with empty metadata had currentTrack->artist()->prettyName() as "Unknown Artist"


- fleissig


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111275/#review35243
-----------------------------------------------------------


On June 28, 2013, 6:32 p.m., fleissig fleissig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111275/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 6:32 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> putting Artist - Title of the current track to the clipboard using a shortcut
> 
> 
> This addresses bug 228872.
>     https://bugs.kde.org/show_bug.cgi?id=228872
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h b2ee08014c110d1979176fe9d4abfad5076c1179 
>   src/MainWindow.cpp af47db7226244cc81f1a4f50000d3c980d758b93 
> 
> Diff: http://git.reviewboard.kde.org/r/111275/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> fleissig fleissig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130628/1764a38d/attachment-0001.html>