Review Request 111275: putting Artist - Title of the current track to the clipboard using a shortcut

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111275/#review35243
-----------------------------------------------------------


Fine patch, I have just 2 minor suggestions.


src/MainWindow.cpp
<http://git.reviewboard.kde.org/r/111275/#comment25807>

    I suggest safety against artist() being null. Note that:
    if( ...->artist() )
        ...->artist()->...
    
    is unsafe, you need a temporary.



src/MainWindow.cpp
<http://git.reviewboard.kde.org/r/111275/#comment25804>

    nitpick: one extra whitespace


- Matěj Laitl


On June 27, 2013, 9:48 p.m., fleissig fleissig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111275/
> -----------------------------------------------------------
> 
> (Updated June 27, 2013, 9:48 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> putting Artist - Title of the current track to the clipboard using a shortcut
> 
> 
> This addresses bug 228872.
>     https://bugs.kde.org/show_bug.cgi?id=228872
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp af47db7226244cc81f1a4f50000d3c980d758b93 
>   src/MainWindow.h b2ee08014c110d1979176fe9d4abfad5076c1179 
> 
> Diff: http://git.reviewboard.kde.org/r/111275/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> fleissig fleissig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130628/b608b6ed/attachment.html>