[amarok] src/playlist: PlaylistController: revert double-clicking to append & start playing if not already

Matěj Laitl matej at laitl.cz
Wed Jun 26 20:24:37 UTC 2013


Git commit a036b39f164ebe8e5060f4ea48bf8854ba6aa87e by Matěj Laitl.
Committed on 26/06/2013 at 20:18.
Pushed by laitl into branch 'master'.

PlaylistController: revert double-clicking to append & start playing if not already

I dislike this behaviour strongly, but it is fair to level the
playing field for the ongoing discussion. This should get the behaviour
to the state before the refactorings, without reverting the (much needed
IMO) refactorings themselves.

CCMAIL: amarok-devel at kde.org

M  +2    -2    src/playlist/PlaylistController.h

http://commits.kde.org/amarok/a036b39f164ebe8e5060f4ea48bf8854ba6aa87e

diff --git a/src/playlist/PlaylistController.h b/src/playlist/PlaylistController.h
index 25d020f..5f96d0e 100644
--- a/src/playlist/PlaylistController.h
+++ b/src/playlist/PlaylistController.h
@@ -55,11 +55,11 @@ enum AddOption
     // bahaviour of similarly-looking UI elements the same. These enums are the preferred
     // ones on calling sites. Feel free to add a new one if you find another UI element
     // that appears on multiple places. Prefix these with On*.
-    OnDoubleClickOnSelectedItems = DirectPlay,
+    OnDoubleClickOnSelectedItems = StartPlay,
     OnMiddleClickOnSelectedItems = 0, // append
     OnReturnPressedOnSelectedItems = OnDoubleClickOnSelectedItems, // these should be kept same
 
-    OnPlayMediaAction = OnDoubleClickOnSelectedItems,
+    OnPlayMediaAction = DirectPlay,
     OnAppendToPlaylistAction = 0, // no-brainer, just for consistency, applied to popup-dropper too
     OnReplacePlaylistAction = Replace, // ditto
     OnQueueToPlaylistAction = Queue,


More information about the Amarok-devel mailing list