Review Request 110187: SVN_SILENT made messages (.desktop file)

[Patrick von Reth]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110187/
-----------------------------------------------------------

(Updated July 18, 2013, 12:10 p.m.)


Review request for Amarok.


Changes
-------

use qvector


Summary (updated)
-----------------

SVN_SILENT made messages (.desktop file)


Description
-------

Don't communicate with mysql by env vars and autogenerated files

Instead of generating the my.cnf every time amarok starts and to pass
the location of this file by setting an environment variable directly
pass the settings as arguments to mysql. As this is probably a better
approach and the only one working on windows.

This fixes an issue where amarok is writing the database to "C:\Program Files (x86)\Amarok\data\amarok".
This issue prevents Amarok from running correctly, because regarding to the rights of the useraccount the directory can be not writeable.

The commands used are taken from the output of "mysqld --verbose --help". 


Diffs (updated)
-----

  src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp 0233498fdeb18ab51e709e9a78384fc37c47cb2a 

Diff: http://git.reviewboard.kde.org/r/110187/diff/


Testing
-------

Only on windows


Thanks,

Patrick von Reth

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130718/e81815de/attachment.html>