Review Request 111552: Week 4 : Revamping Amarok's Scripting Interface

[Anmol Ahuja]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111552/
-----------------------------------------------------------

(Updated July 17, 2013, 10:19 p.m.)


Review request for Amarok and Mark Kretschmann.


Description (updated)
-------

Kinda messy, not even sure if it builds. Everything will be cleaned up by the next week, including the existing API.


Diffs
-----

  src/CMakeLists.txt 69a8ff4 
  src/scriptconsole/CompletionModel.h PRE-CREATION 
  src/scriptconsole/CompletionModel.cpp PRE-CREATION 
  src/scriptconsole/ScriptConsole.h PRE-CREATION 
  src/scriptconsole/ScriptConsole.cpp PRE-CREATION 
  src/scriptconsole/ScriptConsole.ui PRE-CREATION 
  src/scriptconsole/ScriptConsoleItem.h PRE-CREATION 
  src/scriptconsole/ScriptConsoleItem.cpp PRE-CREATION 
  src/scriptconsole/ScriptEditorDocument.cpp PRE-CREATION 
  src/scriptconsole/ScriptItemDelegate.cpp PRE-CREATION 
  src/scriptengine/AmarokCollectionScript.h 5733947 
  src/scriptengine/AmarokCollectionScript.cpp 3fcda84 
  src/scriptengine/AmarokEngineScript.h aa2b112 
  src/scriptengine/AmarokEngineScript.cpp 5471838 
  src/scriptengine/AmarokInfoScript.h 754498e 
  src/scriptengine/AmarokInfoScript.cpp 4d06568 
  src/scriptengine/AmarokKNotifyScript.h 720f9f6 
  src/scriptengine/AmarokKNotifyScript.cpp b98efed 
  src/scriptengine/AmarokLyricsScript.h a47c609 
  src/scriptengine/AmarokNetworkScript.h 0af0f9b 
  src/scriptengine/AmarokNetworkScript.cpp 0eaa440 
  src/scriptengine/AmarokOSDScript.h 992fcee 
  src/scriptengine/AmarokOSDScript.cpp 659cd68 
  src/scriptengine/AmarokPlaylistScript.h 28f9d7e 
  src/scriptengine/AmarokScript.h 891927d 
  src/scriptengine/AmarokScriptConfig.h 2f72890 
  src/scriptengine/AmarokScriptConfig.cpp 457104a 
  src/scriptengine/AmarokScriptableServiceScript.h 6dbe4b5 
  src/scriptengine/AmarokScriptableServiceScript.cpp a312671 
  src/scriptengine/AmarokServicePluginManagerScript.h 6851dc7 
  src/scriptengine/AmarokStatusbarScript.h c871213 
  src/scriptengine/AmarokStreamItemScript.h PRE-CREATION 
  src/scriptengine/AmarokStreamItemScript.cpp PRE-CREATION 
  src/scriptengine/AmarokWindowScript.h 5b18e18 
  src/scriptengine/PHAACG2.py PRE-CREATION 
  src/scriptengine/ScriptImporter.h 7de9a4c 
  src/scriptengine/ScriptingDefines.h PRE-CREATION 
  src/scriptengine/ScriptingDefines.cpp PRE-CREATION 
  src/scriptengine/exporters/CollectionTypeExporter.h PRE-CREATION 
  src/scriptengine/exporters/CollectionTypeExporter.cpp PRE-CREATION 
  src/scriptengine/exporters/MetaTypeExporter.h PRE-CREATION 
  src/scriptengine/exporters/QueryMakerExporter.h PRE-CREATION 
  src/scriptmanager/ScriptItem.h PRE-CREATION 
  src/scriptmanager/ScriptItem.cpp PRE-CREATION 
  src/scriptmanager/ScriptManager.h PRE-CREATION 
  src/scriptmanager/ScriptManager.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111552/diff/


Testing
-------


Thanks,

Anmol Ahuja

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130717/d044ef20/attachment.html>