Review Request 109040: Support for loading asx playlists.

[Matěj Laitl]

> On Feb. 19, 2013, noon, Edward Hades Toroshchin wrote:
> > Thanks for the patch.
> > 
> > Unfortunately we won't be able to accept it, because someone else is already working on ASX playlist as well as on general playlist code cleanup.
> > 
> > In the future, please ask us before you do any work on Amarok, to prevent wasted efforts.
> > 
> > We're looking forward to your future contributions!

Usually, little duplication doesn't matter and nothing prevents 2 people from working on the same thing - we just merge the work that has higher quality or is merge-ready fists.

However, this one is a bit special, because the other review request started with general (much needed) cleanups in file-playlist code and was long stuck because lack of Amarok developer time to review it. Be assured that it is very exceptional for us to reject review requests straight away just because it is already being worked on by someone else.

Generally, we of course don't require contributors to ask whether they can work on a specific feature. However, it is always nice to say "Hi, I'm working on this and I think I will use libXY to do it..." on the related bug report. (which was not the case with the other report, sorry about that)


- Matěj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109040/#review27719
-----------------------------------------------------------


On Feb. 19, 2013, 11:37 a.m., Joel Mandell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109040/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 11:37 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> According to request #170207 - https://bugs.kde.org/show_bug.cgi?id=170207
> Patches to add basic support for loading asx playlist files.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109040/diff/
> 
> 
> Testing
> -------
> 
> Loaded different kind of asx files. Seems okay to me!
> 
> 
> Thanks,
> 
> Joel Mandell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130219/9d31d2d9/attachment.html>