Review Request 109040: Support for loading asx playlists.

Edward Hades Toroshchin edward.hades at gmail.com
Tue Feb 19 12:00:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109040/#review27719
-----------------------------------------------------------


Thanks for the patch.

Unfortunately we won't be able to accept it, because someone else is already working on ASX playlist as well as on general playlist code cleanup.

In the future, please ask us before you do any work on Amarok, to prevent wasted efforts.

We're looking forward to your future contributions!

- Edward Hades Toroshchin


On Feb. 19, 2013, 11:37 a.m., Joel Mandell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109040/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 11:37 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> According to request #170207 - https://bugs.kde.org/show_bug.cgi?id=170207
> Patches to add basic support for loading asx playlist files.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109040/diff/
> 
> 
> Testing
> -------
> 
> Loaded different kind of asx files. Seems okay to me!
> 
> 
> Thanks,
> 
> Joel Mandell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130219/a5ae4252/attachment.html>


More information about the Amarok-devel mailing list